Open AlfredBeNoel opened 11 months ago
I did fail to mention that "the FindCommandParser class is called first which then creates a new instance of the FindCommand class in the FindCommandParser#parse", but I also need to state that I don't think it's a major bug because the part I wrote is completely correct, I just wrote out this step. And in the DG, we have clearly labeled the logic part of the command structure schematic, so I don't think this can be considered as "Medium".
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: The FindCommand
fails to mention how it filters the entries using the model.updateFilteredPersonList(predicate)
to filter the person list to find the number of matches, hence the flow itself is missing important steps. Although the Logic
section mentions about how it works, there is no part is the DG that mentions about what the FindCommandParser
specifically either.
These are critical information needed for the developer, in better understanding what and how the code functions.
The
FindCommandParser
class is called first which then creates a new instance of theFindCommand
class in theFindCommandParser#parse