AlfredoRamos / phpbb-ext-markdown

Markdown extension for phpBB
GNU General Public License v2.0
9 stars 4 forks source link

Tables not working #14

Closed jonpas closed 5 years ago

jonpas commented 5 years ago

phpBB Markdown Version: dev (6715a8298c28f00de9600234dc660fcee0059d9a)

Tables as documented don't seem to work.

| Left | Center | Right |
|:-----|:------:|------:|
|   x  |    x   |   x   |

results in:

LeftCenterRightxxx

Tried with BBCode enabled and disabled.

AlfredoRamos commented 5 years ago

Which extensions (with versions) do you have enabled?

Mmm... it think the tables parser is working, but the styling is not, otherwise you would get it as plain text. Which style do you use? does it inherit from prosilver?

Could you share the HTML output you get with the inspector?

jonpas commented 5 years ago

Which extensions (with versions) do you have enabled?

Which style do you use? does it inherit from prosilver?

Milk v2

Could you share the HTML output you get with the inspector?

<div class="content">
  LeftCenterRightxxx
  <table>
    <thead>
      <tr></tr>
    </thead>
    <tbody>
      <tr></tr>
    </tbody>
  </table>
</div>
AlfredoRamos commented 5 years ago

That's weird.

Try the following:

Left | Center | Right
:-|:-:|-:
x | x | x

Any errors in the ACP or in the web server logs?

I haven't seen that kind of problems with TextFormatter, I would need to investigate because I can't reproduce that problem and I just noted there's no functional test for tables.

jonpas commented 5 years ago

Try the following:

Same result.

Any errors in the ACP or in the web server logs?

None in ACP and none in Apache/PHP logs.

I haven't seen that kind of problems with TextFormatter, I would need to investigate because I can't reproduce that problem and I just noted there's no functional test for tables.

I can help debug if you give some pointers or data you'd like to get. :)

AlfredoRamos commented 5 years ago

Have you modified the phpBB package in any way? I mean PHP files. The tables passed the unit tests, I'm not sure what could be wrong.

If you have SSH access and composer installed, please run the following commands in that server, in the directory where your board is, and post its content:

composer diagnose
composer show s9e/text-formatter

You can remove private information (paths) if you want, I only need versions (detected by the script) and hashes from source and dist

jonpas commented 5 years ago

Have you modified the phpBB package in any way? I mean PHP files.

No. I have only modified markdown.css before you merged the polls fix.

[snip@snip forum]$ composer diagnose
Checking composer.json: OK
Checking platform settings: OK
Checking git settings: OK
Checking http connectivity to packagist: OK
Checking https connectivity to packagist: OK
Checking github.com rate limit: OK
Checking disk free space: OK
Checking pubkeys:
Composer version: 1.7.2
PHP version: 5.4.7 - Package overridden via config.platform (actual: 7.2.19)
PHP binary path: /snippath/usr/bin/php
[snip@snip forum]$ composer show s9e/text-formatter
name     : s9e/text-formatter
descrip. : Multi-purpose text formatting and markup library. Plugins offer support for BBCodes, Markdown, emoticons, HTML, embedding media (YouTube, etc...), enhanced typography and more.
keywords : bbcode, bbcodes, blog, censor, embed, emoji, emoticons, engine, forum, html, markdown, markup, media, parser, shortcodes
versions : * 1.4.2
type     : library
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
source   : [git] https://github.com/s9e/TextFormatter.git dc7efff70b67b9cee00881ad3bef0a1da076b31e
dist     : [zip] https://api.github.com/repos/s9e/TextFormatter/zipball/dc7efff70b67b9cee00881ad3bef0a1da076b31e dc7efff70b67b9cee00881ad3bef0a1da076b31e
names    : s9e/text-formatter

autoload
psr-4
s9e\TextFormatter\ => src

requires
ext-dom *
ext-filter *
lib-pcre >=7.2
php >=5.4.7

requires (dev)
matthiasmullie/minify *
php-coveralls/php-coveralls *
s9e/regexp-builder 1.*

suggests
ext-curl Improves the performance of the MediaEmbed plugin and some JavaScript minifiers
ext-intl Allows international URLs to be accepted by the URL filter
ext-json Enables the generation of a JavaScript parser
ext-mbstring Improves the performance of the PHP renderer
ext-tokenizer Improves the performance of the PHP renderer
ext-xsl Enables the XSLT renderer
ext-zlib Enables gzip compression when scraping content via the MediaEmbed plugin
AlfredoRamos commented 5 years ago

Can you try with only Markdown extension enabled?

jonpas commented 5 years ago

Disabled all extensions except Markdown, same result.

AlfredoRamos commented 5 years ago

I fear I can't help you further about this issue, I would suggest to report it to the TextFormatter library giving as much information about your server setup as you can.

I can't reproduce your issue and even the tests pass, and with the given information it doesn't seems to be a extension conflict.

I'm sure JoshyPHP can help you better since he's the author of the library I'm using.

jonpas commented 5 years ago

Sounds good, thanks!

AlfredoRamos commented 5 years ago

Oh, I forgot, this is his repository:

https://github.com/s9e/TextFormatter

I'm closing this since it doesn't seems to be a issue of this extension.

jonpas commented 5 years ago

Yes, I am aware, but thanks! :)