AlfredoRamos / phpbb-ext-seo-metadata

SEO Metadata extension for phpBB
GNU General Public License v2.0
11 stars 7 forks source link

helper#extract_image() does not match images with query string in the URL #81

Closed mentos closed 3 years ago

mentos commented 3 years ago

helper#extract_image() does not match images containing a query string in their URL. For example the following image will be ignore due to \.(?:jpe?g|png|gif)$ looking for the file extension to be the last thing in the URL: <img src="www.example.com/my-image.jpg?h=400&w=500" alt="" />.

Query strings in images src is useful when dealing with dynamically sized images and/or caching mechanisms that rely on URL params for cache expiration, so this might be something you want to consider for this extension.

AlfredoRamos commented 3 years ago

Hi :wave:

Thanks for the report, it should be fixed once #82 is merged.