search

AlfredoSequeida / fvid

fvid is a project that aims to encode any file as a video using 1-bit color images to survive compression algorithms for data retrieval.
MIT License
354 stars 43 forks source link

Allow a user to set framerate for encoding with -f #12

Closed Theelx closed 4 years ago

Theelx commented 4 years ago

You might want to format line 203 over two lines. Also I made make_video's new framerate argument default to 1/5 in case it's ever called by a function besides main.

Theelx commented 4 years ago

@AlfredoSequeida Just letting you know I made a small PR for a custom framerate option, it's ready for your review (in case you missed it). Going to sleep now so will be unresponsive for at least 8-9 hours.

Theelx commented 4 years ago

Ok, I just updated the file with the merged commit and the working parser arg. Thanks for the comments, I was confused when reading the argparse docs originally, so I couldn't decide between default and store_const initially, so thanks again for pointing that out!

AlfredoSequeida commented 4 years ago

Looks great! Thank you for your work!