search

AlfredoSequeida / venus

Venus aims to be a cross-platform tool to automatically change your desktop wallpaper to something random using images from Unsplash.
MIT License
25 stars 6 forks source link

add sway support #6

Closed MrYakobo closed 5 years ago

MrYakobo commented 5 years ago

added a try-catch in set_wall, and another one in get_screen_resolution.

AlfredoSequeida commented 5 years ago

Nice! Thank you for this. I'll take a closer look at it later today to see the changes. Also, If you haven't already, please add yourself to the AUTHORS file along with what you added.

AlfredoSequeida commented 5 years ago

@MrYakobo So I had some time to go over the pull request. It works as expected with one exception, I am getting

/bin/sh: xrandr: command not found

after executing venus. This, of course, makes sense because we don't need xrandr for Wayland, but it would be nice not to get any error messages on the screen just for the user's sake.

Also, I made the mistake of merging a later pull request (#7 ) before this one, so just note that there are now some conflicts, but these are simple to resolve. Just adopt the changes in set_wall() and stick with your implementation for get_screen_resolution() since we are adding sway and we need that try/catch block. Again, I apologize for merging the other one first. I am new to having people contribute to a project and I am not yet sure of the procedures.

After resolving the conflicts and removing that error message, we will be ready to merge this change. Again, thank you for your work so far!

MrYakobo commented 5 years ago

No problem with the merge. Made all commands in linux.py silent (redirecting stdout and stderr to /dev/null)

AlfredoSequeida commented 5 years ago

Perfect! Thank you for the changes! I will go ahead and merge the pull request and include the new feature in the next release.