Alfresco / alfresco-docker-installer

Generator to build Docker Compose templates to deploy Alfresco Community
Other
142 stars 57 forks source link

download file with spaces into filename #142

Closed antoniorv75 closed 2 years ago

antoniorv75 commented 2 years ago

Good afternoon. I wondering if someone has the same problem than I am having downloading documents?, I am trying download a file with the repository browser ACS. Example a filename called "Hi there.docx" will be downloaded as "Hi+there.docx". However When I upload the file, the file is showed with the name perfectly into the ACS interface, the problem occurs when you download the file, something changes the spaces by '+'

Any ideas? Thank you in advance. Kind regards.

aborroy commented 2 years ago

I guess you need to upgrade your deployment, that was fixed in: https://github.com/Alfresco/alfresco-community-repo/pull/870

antoniorv75 commented 2 years ago

thank you @aborroy , I'll try it. note: Following your alfresco-docker-installer, I have installed the identical version than you provide with your alfresco-docker-installer.

ALFRESCO_CE_TAG=7.2.0 SEARCH_CE_TAG=2.0.3 SHARE_TAG=7.2.0 ACA_TAG=2.9.0 POSTGRES_TAG=13.3 MARIADB_TAG=10.5 TRANSFORM_ENGINE_TAG=2.5.7 ACTIVEMQ_TAG=5.16.1

should I have to make changes in your scripts according the versions from here https://github.com/Alfresco/acs-deployment/blob/master/docker-compose/community-docker-compose.yml ?

antoniorv75 commented 2 years ago

I guess you need to upgrade your deployment, that was fixed in: Alfresco/alfresco-community-repo#870

I checked the last version and the other ones too just in case only to detect what could be the version where this problem starts. With 7.2 and forward seem the problem persists inspite of https://github.com/Alfresco/alfresco-community-repo/pull/870 indicates the patch is applied already.. it's curious from 7.2 backwards this behaviours is not occurs. The patch is not applied apparentely, i really don't know if the team are aware about that, because this seem a problem really easy to solve. When you try download a file it not runs but if you try view in browser, the file is downloaded perfectly, that's very curious.

Thank you for your time @aborroy

aborroy commented 2 years ago

Can you try using these versions?

ALFRESCO_CE_TAG=7.2.0.1 SHARE_TAG=7.2.0.2

antoniorv75 commented 2 years ago

Yes, it's a pity, the problem still occurs. :(

aborroy commented 2 years ago

I've create this patch to solve the problem: https://github.com/aborroy/mnt-22668

Let me know if that helps.

antoniorv75 commented 2 years ago

Thank you @aborroy , sorry but in order to install it following your alfresco-docker-installer , In which directory I have to put the file? could be /alfresco/modules/amps ?

aborroy commented 2 years ago

You're right

antoniorv75 commented 2 years ago

Puff, the problem persist, if I check with your docker-installer quicky following the 7.2 version, I found the same problem. The amp file is installed under .../alfresco/modules/amps and I run the docker-compose up --build -d Everything run fine but when I try to download from : http:///share/page/site/swsdp/documentlibrary#filter=path%7C%2FMeeting%2520Notes%7C&page=1 and I make click into different files in some of them the problem persists in two files, but not in other one.... this is curious. image

image

aborroy commented 2 years ago

That might be related with Browser cache. May you try with a different browser or using incognito mode?

antoniorv75 commented 2 years ago

Hi @aborroy , It works!, the problem was the cache. Thank you very much, I hope this patch with be merged with the next release, if not I shouldn't update until it would be ready. (I just have checked in a 7.3 mockup and I seems works too)

antoniorv75 commented 2 years ago

Thank you @aborroy , I think this issue might be closed. Gracias @aborroy , está todo ya terminado y creo que vamos a cerrar esta issue. Un abrazo.