Alfresco / alfresco-docker-installer

Generator to build Docker Compose templates to deploy Alfresco Community
Other
140 stars 57 forks source link

`acsVersion` has incorrect type when provided as parameter #194

Closed vargiuscuola closed 5 months ago

vargiuscuola commented 5 months ago

When providing the parameter --acsVersion=<version> to the installer, the property this.props.acsVersion has number type, and it fails with the Invalid argument expected string error.

All instructions which treat it as a string will fail, such as:

As a quick fix, I modify the scripts forcing a type conversion with the following commands:

sed --in-place -E 's/(writing\(\).*)$/\1\n    this.props.acsVersion = String(this.props.acsVersion);/' generators/app/index.js
sed --in-place -E "s/(const validateAndParse.*)$/\1\n        version = String(version);/" node_modules/compare-versions/lib/umd/index.js
aborroy commented 5 months ago

Thanks for your contribution. This issue has been patched in 0.9.1 release.