Alfresco / alfresco-ng2-components

Alfresco Angular Components
https://www.alfresco.com/abn/adf/docs/
Apache License 2.0
294 stars 268 forks source link

[ACS-8634] "Manage Searches" - a full page list of saved searches #10307

Closed dominikiwanekhyland closed 1 month ago

dominikiwanekhyland commented 1 month ago

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation
  • [ ] Other... Please describe:

What is the current behaviour? (You can also link to an open issue here) https://hyland.atlassian.net/browse/ACS-8634

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

swapnil-verma-gl commented 1 month ago

something I noticed while testing. When doing a new search, the loading bar is no longer visible. This does not seem to happen on the current ACADEV env. See video below - https://github.com/user-attachments/assets/d51b2fb7-2fe4-459e-bb11-f6a364929cfd Also, there is a light blue border above the datatable component in personal files. This is also not present on the ACADEV env

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud