search

Alfresco / alfresco-ng2-components

Alfresco Angular Components
https://www.alfresco.com/abn/adf/docs/
Apache License 2.0
294 stars 268 forks source link

[ACS-8921][ACA] Data Table / The input field in "Filter by Name" dialog is enormous in comparison with the UI design #10375

Closed dominikiwanekhyland closed 2 weeks ago

dominikiwanekhyland commented 3 weeks ago

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation
  • [ ] Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/ACS-8921

What is the new behaviour? Filter is fixed

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

swapnil-verma-gl commented 3 weeks ago

I just took a look at the JIRA, and there is a much simpler way of resolving this bug. All that is needed, is to remove the appearance=outline property from the input text field in HTML (located here). That changes the UI of the text field to something more consistent with the rest of the application. Additionally, it also allows us to remove the mat-selectors from the scss file as well. I tried on my local with the proposed change, and a completely empty scss file and it looked fine, except for some minor padding/spacing issues, which should not be too hard to fix.

On a side note, I remember this bug being fixed during the ng15 upgrade as well (see ACS-8429). Don't know what caused it to re-appear, could be a miss during rebase. But regardless, we should probably make sure not to miss it during the ng17 upgrade

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud