Alfresco / alfresco-sdk

The Alfresco In-Process SDK is based on Apache Maven, includes support for rapid and standard development, testing, packaging, versioning and release of your Alfresco integration and extension projects
Apache License 2.0
186 stars 113 forks source link

Make the Maven plugin log when it installs an AMP #274

Closed slanglois closed 9 years ago

slanglois commented 9 years ago

The install goal of the Maven plugin does not log anything, which is not very standard and confused me a few times:

[INFO] --- alfresco-maven-plugin:2.0.0:install (install-amps) @ alfresco-enterprise ---
[INFO]

It would be nice to have at least a line with level [INFO] telling which AMP file is installed and where. That especially makes sense since you can pass a folder of AMPs to have all of them installed. The log could be something like:

[INFO] --- alfresco-maven-plugin:2.0.0:install (install-amps) @ alfresco-enterprise ---
[INFO] Installing /blabla/toto.amp into /foo/bar/target/alfresco.war
[INFO]

Additionally, if it's not too complicated, it would be even nicer to display the id and version from the module.properties, if available:

[INFO] --- alfresco-maven-plugin:2.0.0:install (install-amps) @ alfresco-enterprise ---    [INFO] Installing AMP files into /foo/bar/target/alfresco.war
[INFO] /blabla/alfresco-share-services.amp (alfresco-share-services version 5.1.0)
[INFO] /blibli/alfresco-rm-2.3.amp (org_alfresco_module_rm  version 2.3)
[INFO]
gravitonian commented 9 years ago

Linked to https://issues.alfresco.com/jira/browse/DEVPLAT-57

mindthegab commented 9 years ago

I have added an initial logging, you can test in 2.1.1-SNAPSHOT. modules.properties is not that easy. Can we use the project version and assume those 2 (pom version and module.properties) are always the same (can't think why it should be different).

mindthegab commented 9 years ago

@slanglois Can you test if this works for you (with 2.1.1-SNAPSHOT)? Assigning the issue to you.

Thanks!

slanglois commented 9 years ago
[INFO] --- alfresco-maven-plugin:2.1.1-SNAPSHOT:install (install-amps) @ alfresco ---
[INFO] Installing all AMPs from directory d:\work\web-apps\Share\branches\RA-SPRINT6\alfresco\target\amps into WAR/exploded webapp at d:\work\web-apps\Share\branches\RA-SPRINT6\alfresco\target\alfresco.war
[INFO] AMPs installed successfully

OK, that will do! Thanks