Alfresco / alfresco-sdk

The Alfresco In-Process SDK is based on Apache Maven, includes support for rapid and standard development, testing, packaging, versioning and release of your Alfresco integration and extension projects
Apache License 2.0
186 stars 113 forks source link

Redundant fileSet in SDK 4 all in one archetype-metadata.xml? #535

Closed binduwavell closed 5 years ago

binduwavell commented 5 years ago

The first fileSet appears to be redundant for <module id="${rootArtifactId}-platform-docker"

            <fileSets>
                <fileSet encoding="UTF-8" filtered="false">
                    <directory>src/main/docker/license</directory>
                    <includes>
                        <include>**</include>
                    </includes>
                </fileSet>
                <fileSet encoding="UTF-8" filtered="false">
                    <directory>src/main/docker</directory>
                    <includes>
                        <include>license/**</include>
                        <include>Dockerfile</include>
                        <include>disable-webscript-caching-context.xml</include>
                    </includes>
                    <excludes>
                        <exclude>**/*.properties</exclude>
                    </excludes>
                </fileSet>
                <fileSet encoding="UTF-8" filtered="true">
                    <directory>src/main/docker</directory>
                    <includes>
                        <include>**/*.properties</include>
                    </includes>
                    <excludes>
                        <exclude>license/**</exclude>
                        <exclude>Dockerfile</exclude>
                        <exclude>disable-webscript-caching-context.xml</exclude>
                    </excludes>
                </fileSet>
            </fileSets>

I have not performed an exhaustive analysis of this file, just ran into this while debugging something else.

ohej commented 5 years ago

Fixed by #537