search

Alfresco / alfresco-sdk

The Alfresco In-Process SDK is based on Apache Maven, includes support for rapid and standard development, testing, packaging, versioning and release of your Alfresco integration and extension projects
Apache License 2.0
185 stars 113 forks source link

Redendant maven-dependency-plugin in -platform-docker and -share-docker modules in SDK 4 #539

Closed binduwavell closed 5 years ago

binduwavell commented 5 years ago

In the rootArtifactId-platform-docker and rootArtifactId-share-docker pom.files there is the following build plugin:

    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-dependency-plugin</artifactId>
                <version>3.0.2</version>
                <executions>
                    <!-- Copy the share extension -->
                    <execution>
                        <id>copy-repo-extension</id>
                        <phase>pre-integration-test</phase>
                        <goals>
                            <goal>copy</goal>
                        </goals>
                        <configuration>
                            <artifactItems>
                                <artifactItem>

The first <artifactItem> is 

                                <artifactItem>
                                    <groupId>com.ziaconsulting</groupId>
                                    <artifactId>alfsdk4-platform-jar</artifactId>
                                    <version>1.0-SNAPSHOT</version>
                                    <overWrite>false</overWrite>
                                    <outputDirectory>${project.build.directory}/extensions</outputDirectory>
                                </artifactItem>

and

                                <artifactItem>
                                    <groupId>com.ziaconsulting</groupId>
                                    <artifactId>alfsdk4-share-jar</artifactId>
                                    <version>1.0-SNAPSHOT</version>
                                    <overWrite>false</overWrite>
                                    <outputDirectory>${project.build.directory}/extensions</outputDirectory>
                                </artifactItem>

Are these needed given the following?

                    <!-- Copy other dependencies (JARs or AMPs) declared in the platform module -->
                    <execution>
                        <id>copy-third-party-dependencies</id>
                        <phase>pre-integration-test</phase>
                        <goals>
                            <goal>copy-dependencies</goal>
                        </goals>
                        <configuration>
                            <outputDirectory>${project.build.directory}/extensions</outputDirectory>
                            <includeScope>runtime</includeScope>
                        </configuration>
                    </execution>
ohej commented 5 years ago

Fixed in #524