search

Alfresco / rest-api-explorer

Public REST API Explorer
Apache License 2.0
36 stars 25 forks source link

ACS-4966 Add path to Category model #189

Closed MichalKinas closed 1 year ago

MichalKinas commented 1 year ago

https://alfresco.atlassian.net/browse/ACS-4966 This PR is about adding path param to Categories API.

tpage-alfresco commented 1 year ago

Sorry - I added people prematurely to this PR. @MichalKinas You haven't added a description about the new include=path option to the category endpoints.

MichalKinas commented 1 year ago

Sorry - I added people prematurely to this PR. @MichalKinas You haven't added a description about the new include=path option to the category endpoints.

Right thank you, added now

azakrzewski-hy commented 1 year ago

Sorry - I added people prematurely to this PR. @MichalKinas You haven't added a description about the new include=path option to the category endpoints.

Right thank you, added now

Should we keep * path field in both descriptions: for categoryEntryIncludeParam and categoryEntryIncludePathParam ?

MichalKinas commented 1 year ago

Sorry - I added people prematurely to this PR. @MichalKinas You haven't added a description about the new include=path option to the category endpoints.

Right thank you, added now

Should we keep * path field in both descriptions: for categoryEntryIncludeParam and categoryEntryIncludePathParam ?

Yes categoryEntryIncludeParam is used when both count and path options are available and categoryEntryIncludePathParam is used when only path option is available for given endpoint

tpage-alfresco commented 1 year ago

I think you're still missing some endpoints in this change. I think you added include=path to GET category, PUT category, GET subcategories, POST subcategories, GET nodes/{id}/categories and POST nodes/{id}/categories in the other PR.

MichalKinas commented 1 year ago

I think you're still missing some endpoints in this change. I think you added include=path to GET category, PUT category, GET subcategories, POST subcategories, GET nodes/{id}/categories and POST nodes/{id}/categories in the other PR.

@tpage-alfresco are you sure? I've just double checked and each Category related endpoint except DELETE has include=path added in its description.