AlfrescoArchive / activiti-cloud-charts

Helm Charts for Activiti cloud Apps
Apache License 2.0
29 stars 28 forks source link

ACTIVITI-2645 Make audit + query + rb use the postgres found in the a… #42

Closed roxanaspatariu closed 5 years ago

roxanaspatariu commented 5 years ago

Make audit + query + rb use the postgres found in the application namespace

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

ryandawsonuk commented 5 years ago

The changes look fine to me. Are there further changes coming? I ask because it will take us a while to apply the same changes to the other places where we have these charts as each of our example repositories has its own chart (just for runtime bundle these are example-runtime-bundle, ttc-rb-english-campaign and activiti-cloud-runtime-bundle-quickstart). So it would be good know that we've got all the changes in one go.

ffazzini commented 5 years ago

sounds great @ryandawsonuk
As a last step we want to test the activiti cloud chart to make sure we are able to use an external postgres too. As a result of this test we won't have any postgres deployed in kubernetes. Sounds good?

ryandawsonuk commented 5 years ago

I was assuming that these changes were being proposed as a result of testing. I guess there's a further scenario that also needs testing?

ffazzini commented 5 years ago

@ryandawsonuk yes the scenario i described above, have you already tested it?

roxanaspatariu commented 5 years ago

We just tested the charts on an external db and it works fine. One example for this would be:

runtime-bundle:
  enabled: true
  db:
    uri: jdbc:postgresql://*.rds.amazonaws.com/activitidb
    username: alfresco
    password: changeme
    driver: org.postgresql.Driver
    platform: org.hibernate.dialect.PostgreSQLDialect
    generateDdl: true
    ddlAuto: update