Closed igdianov closed 5 years ago
@igdianov why do we need an ingress path for the actuator? I want to be sure that I understand why is that a requirement in the templates.
@mteodori I thought it would make sense to make Ingress endpoints configurable, i.e. disable | enable /graphiql
or /actuator
if someone wants. I think it is a good practice to make all configuration values explicit, but simplify configuration using templates with feature toggles. I like to have opinionated configuration but without hard coding the templates.
@mteodori @salaboy I realized that we cannot expose Notifications /actuator
endpoint because of the conflict with Gateway /actuator
, so I propose to expose Notifications service endpoints under /notifications
default base path. The base path can overridden using /{{.Release.Name}}/notifications
template in AAE.
We will need to update the NOTES.txt
in activiti-full-example-chart
and documentation to reflect this breaking change.
@igdianov yeah.. I totally like that /notifications is the way to go.. so we can finally map endpoints to building blocks in the website :)
Also, the acceptance tests should be changed to support new /notifications
endpoint url.
All good for me
This PR adds ingress path to expose Notifications service /actuator endpoint. However, in order to avoid conflict with the Gateway /actuator, the base path for Notifications ingress has been changed to
/notifications
.Part of https://github.com/Activiti/Activiti/issues/2720