AlfrescoArchive / activiti-cloud-charts

Helm Charts for Activiti cloud Apps
Apache License 2.0
29 stars 28 forks source link

Make the rb name compliant with ADF by default #67

Open mauriziovitale opened 5 years ago

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

salaboy commented 5 years ago

@igdianov I wouldn't merge this until we fix the internal charts and then we start renaming. I wouldn't also change this at the helm chart level, I would like to change it at the spring boot app level. The current convention used for names in the product doesn't make too much sense for community modules due several restrictions. We can make their life simpler by renaming the right things in the right places, but I don't want those restrictions to creep in the community space.

mauriziovitale commented 5 years ago

@mauriziovitale What about query and audit service names used by ADF, i.e. rb-query and rb-audit?

The query is not a problem because the service is already called name: query some for audit name: audit @salaboy If we don't do that we need to have documentation that says to replace the rb service name from name: rb-my-app to name: rb otherwise ADF won't work!

magemello commented 5 years ago

just a remainder we already agreed on names which are:

/audit /query /rb /notifications /modeling-service /modeling /identity.{domain}/auth /gateway.{domain}/

igdianov commented 5 years ago

@mauriziovitale @salaboy We will merge this when it is time.

salaboy commented 5 years ago

@igdianov please do not merge.. I see some issues here.. if we want to change the service names, we should change them in the service itself. I would like to remove from the default values file the "service" -> "name" is it should be defaulted from the Kubernetes Service Descriptor which should use the spring.application.name

igdianov commented 5 years ago

@salaboy Makes sense to me. We should fix the source rather than patch the chart.