Algafix / OSNMA

A python implementation of the Galileo OSNMA protocol.
European Union Public License 1.2
40 stars 12 forks source link

Broken code after first Galmon data authentication #12

Closed PaulZabalegui closed 10 months ago

PaulZabalegui commented 10 months ago

Hi,

I've been using this repository for this last month and it's been really helpful, thanks!

I'm afraid to tell you that I'm having the following issue with this last release when using the runner for Galmon data. After authenticating ADKDs the first time, the code breaks at:

 File "run.py", line 24, in live_galmon_config
    osnma_r.start()
  File "~./osnma/receiver/receiver.py", line 122, in start
    self.receiver_state.process_mack_subframe(mack_sf, gst_sf, satellite.svid, nma_status)
  File "~./osnma/osnma_core/receiver_state.py", line 413, in process_mack_subframe
    self.tesla_chain_force.parse_mack_message(w_mack[0], w_mack[1], w_mack[2], w_mack[3])
  File "~./osnma/osnma_core/tesla_chain.py", line 172, in parse_mack_message
    self.tags_structure.update_tag_lists(gst_sf)
  File "~./osnma/osnma_core/tag_verification.py", line 160, in update_tag_lists
    tag.nav_data  = self.nav_data_m.get_data(tag)
  File "~./osnma/osnma_core/nav_data_manager.py", line 387, in get_data
    nav_data = self.adkd0_data_managers[svid].get_nav_data(tag)
  File "~./osnma/osnma_core/nav_data_manager.py", line 243, in get_nav_data
    if data.gst_completed and data.gst_completed > gst_start_tesla_key - Config.TL:
AttributeError: 'NoneType' object has no attribute 'gst_completed'

Can you replicate the error? I've added an Ublox parser to the library and I'm not getting this error, if that helps.

Algafix commented 10 months ago

Thank you for reporting the problem!

I changed a few things on the tag-data link and some leftovers from the previous version were causing issues in some corner cases (the galmon network is usually a good way of detecting those).

Find a new release v2.1.1 with the fix :)

PaulZabalegui commented 10 months ago

Thanks! It Works perfectly now!

Gracias!

[CEIT]https://urldefense.com/v3/__http:/www.ceit.es/__;!!MvyJQugb!G9Gp2OG6wUTg6h-Dd1kk8JLXF7PxukGQOF-LlKar43oNfBTHEPwy0DArYb6boNQkLh8ZdP5D9xi6AZXm4MmWc8EQ$ PhD. Paul Zabalegui Landa Research Scientist Sustainable Mobility and Transport Tel: 943 212 800 / Ext. 2953 @.**@.> https://www.ceit.es/es/areas-investigacion/transporte-energia/transporte-movilidad-sosteniblehttps://urldefense.com/v3/__https:/www.ceit.es/es/areas-investigacion/transporte-energia/transporte-movilidad-sostenible__;!!MvyJQugb!G9Gp2OG6wUTg6h-Dd1kk8JLXF7PxukGQOF-LlKar43oNfBTHEPwy0DArYb6boNQkLh8ZdP5D9xi6AZXm4C5FgsC0$ @.***https://urldefense.com/v3/__https:/orcid.org/0000-0003-0906-1654__;!!MvyJQugb!G9Gp2OG6wUTg6h-Dd1kk8JLXF7PxukGQOF-LlKar43oNfBTHEPwy0DArYb6boNQkLh8ZdP5D9xi6AZXm4KSLtrEx$

De: Aleix @.> Enviado el: lunes, 27 de noviembre de 2023 15:50 Para: Algafix/OSNMA @.> CC: Zabalegui Landa, Paul @.>; Author @.> Asunto: Re: [Algafix/OSNMA] Broken code after first Galmon data authentication (Issue #12)

Thank you for reporting the problem!

I changed a few things on the tag-data link and some leftovers from the previous version were causing issues in some corner cases (the galmon network is usually a good way of detecting those).

Find a new release v2.1.1 with the fix :)

— Reply to this email directly, view it on GitHubhttps://github.com/Algafix/OSNMA/issues/12#issuecomment-1827982480, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQJWSD7NIQIZ2H2NYFZHCXDYGSR77AVCNFSM6AAAAAA74CJ3X6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRXHE4DENBYGA. You are receiving this because you authored the thread.Message ID: @.**@.>>

Este mensaje puede contener información confidencial. Si usted no es el destinatario o lo ha recibido por error, por favor, bórrelo de sus sistemas y comuníquelo a la mayor brevedad al remitente. Los datos personales incluidos en los correos electrónicos que intercambie con el personal de Ceit podrán ser almacenados en la libreta de direcciones de su interlocutor y/o en los servidores de Ceit durante el tiempo fijado en su política interna de conservación de información. Ceit gestiona dichos datos con fines meramente operativos, para permitir el contacto por email entre sus trabajadores/colaboradores y terceros. Puede consultar la Política de Privacidad de Ceit en la dirección: https://ceit.es/es/informacion-legal

Mezu honek isilpeko informazioa izan dezake. Mezuaren hartzailea ez bazara edo akats baten ondorioz jaso baduzu, ezaba ezazu zure sistemetatik, mesedez, eta eman horren berri igorleari. Ceit-eko langileekin trukatutako mezu elektronikoetako datu pertsonalak solaskidearen helbide-libretan eta Ceit-en zerbitzarietan gorde daitezke denbora batez; epe hori Ceit-ek informazioa gordetzeari buruz duen barne-politikan zehazten da. Ceit-ek laneko eginkizunetarako soilik kudeatzen ditu datu horiek, bere langileen eta kolaboratzaileen eta hirugarren batzuen artean posta elektroniko bidezko harremana bideratzeko. Helbide honetan duzu Ceit-eko pribatutasun-politika https://ceit.es/es/informacion-legal

This email message may contain confidential information. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and then delete this message and any attachments. The personal information included in email messages exchanged with employees of Ceit may be stored in the database of your interlocutor and/or the servers of Ceit for the time-period stipulated by its internal information storage policy. Ceit stores such data for purely administrative purposes, to facilitate e-mail contact between its employees and third parties. The Ceit Privacy Policy may be accessed at https://ceit.es/es/informacion-legal

Antes de imprimir este mensaje o sus documentos anexos, asegúrese de que es necesario. Proteger el medio ambiente está en nuestras manos.

Mezu hau edo erantsita dituen dokumentuak inprimatu aurretik, ziurtatu beharrezkoa dela. Ingurumena babestea gure esku dago.

Before printing this e-mail or attachments, be sure it is necessary. It is in our hands to protect the environment.