Algatux / influxdb-bundle

Bundle service integration of official influxdb/influxdb-php client
MIT License
24 stars 14 forks source link

Bundle class should be vendor prefixed #62

Closed soullivaneuh closed 8 months ago

soullivaneuh commented 8 years ago

It should be AlgatuxInfluxDbBundle and not just InfluxDbBundle to reduce possible bundle conflicts.

This is the adopted way for 99% of external bundles as you can see on this AppKernel extract:

new FOS\UserBundle\FOSUserBundle(),
new FOS\OAuthServerBundle\FOSOAuthServerBundle(),
new FOS\RestBundle\FOSRestBundle(),
new FOS\JsRoutingBundle\FOSJsRoutingBundle(),
new Nelmio\ApiDocBundle\NelmioApiDocBundle(),
new Gregwar\ImageBundle\GregwarImageBundle(),
new Sonata\CoreBundle\SonataCoreBundle(),
new Sonata\BlockBundle\SonataBlockBundle(),
new Sonata\DoctrineORMAdminBundle\SonataDoctrineORMAdminBundle(),
new Sonata\AdminBundle\SonataAdminBundle(),
new Sonata\IntlBundle\SonataIntlBundle(),
new Ornicar\GravatarBundle\OrnicarGravatarBundle(),
new Lexik\Bundle\JWTAuthenticationBundle\LexikJWTAuthenticationBundle(),
new Rollerworks\Bundle\PasswordStrengthBundle\RollerworksPasswordStrengthBundle(),
new Hackzilla\Bundle\PasswordGeneratorBundle\HackzillaPasswordGeneratorBundle(),
new A2lix\TranslationFormBundle\A2lixTranslationFormBundle(),
new Browscap\BrowscapBundle\BrowscapBundle(),
new Hautelook\AliceBundle\HautelookAliceBundle(),
new Algatux\InfluxDbBundle\InfluxDbBundle(),
new Greg0ire\Enum\Bridge\Symfony\Bundle\Greg0ireEnumBundle(),

This can be done on a BC way by deprecating the old bundle class name.

Algatux commented 8 years ago

Ok we ll do it

soullivaneuh commented 8 months ago

We can take benefit of the not yet stable 3.0 release to make the change.