search

Algatux / influxdb-bundle

Bundle service integration of official influxdb/influxdb-php client
MIT License
24 stars 14 forks source link

[WIP] Web profiler integration #63

Closed soullivaneuh closed 7 years ago

soullivaneuh commented 8 years ago

Closes #56

This is just a WIP POC to integrate this bundle onto the Web profiler.

This PR is a lab to see together what can be done, or not, for this part.

Profiler toolbar screenshots:

selection_971 selection_972

Algatux commented 8 years ago

:open_mouth: great! :+1:

Algatux commented 8 years ago

Thought about this! As said we need to encapsulate Influx object into some our ones to catch all the executed queries. Trying to figure out an easy way

soullivaneuh commented 8 years ago

Yeah, currently it's just fake data to work on the toolbar design. :wink:

soullivaneuh commented 8 years ago

As said we need to encapsulate Influx object into some our ones to catch all the executed queries. Trying to figure out an easy way

Maybe we can suggest query profiling as a PR on influx core library and then, use it here?

Algatux commented 8 years ago

It s a possibility. We can try but I feel that will not be accepted because you have everything in your hands using the library

soullivaneuh commented 8 years ago

but I feel that will not be accepted because you have everything in your hands using the library

Maybe. We have to elaborate good arguments.

But I think this is not so hard to implement a system that optionally store executed queries to be recuperated from getters.

Because indeed, if they don't accept that, we have to wrapping all Database methods. This would be quite cumbersome.

Algatux commented 8 years ago

@Soullivaneuh I've implemented something similar in https://github.com/facile-it/mongodb-bundle