Algatux / influxdb-bundle

Bundle service integration of official influxdb/influxdb-php client
MIT License
24 stars 14 forks source link

Drop Symfony 2.8 support, add Symfony 5 support, set PHP requirements to ^7.2 #92

Closed Kocal closed 4 years ago

Kocal commented 4 years ago

This PR is a proposal for Symfony 5.0 support.

Also, I've seen issue #89 and #88 while working on this PR. I think it's ok to drop support of Symfony 2.8 and up PHP requirements to PHP 7.1 here, but I can remove those commits if needed. :+1:

EDIT: we have some issues on Travis:

What do you think of:

Another solution is to set PHP requirement to ^7.2 which is still maintained unlike 7.1: https://www.php.net/supported-versions.php

Algatux commented 4 years ago

@Kocal thanks for your contribution! I will look at it asap

Algatux commented 4 years ago

@Kocal about the php issue I was thinking about bumping the requirement up to 7.2 because 7.1 reached its end of life. What do you think @soullivaneuh ?

Still looking at other issues

Kocal commented 4 years ago

Hi, is there any updates on this? I think I will go for PHP 7.2 as minimum requirement

Kocal commented 4 years ago

CI is nearly green everywhere except for Symfony 4.0 :/ image

I don't really have time to investigate the issue, I will now use my fork for SF5 support.

Thanks

tristanbes commented 4 years ago

thank you @Kocal

Algatux commented 4 years ago

@Kocal because of the bc introduced by bumping up the requirements I have to release a new major version. I think I will create a new 3.0 beta to test it and fix the test suite issues

Kocal commented 4 years ago

Great, thanks you!

tristanbes commented 4 years ago

@Algatux did you had the chance to address: https://github.com/Algatux/influxdb-bundle/pull/92#issuecomment-609420066 ?

Kocal commented 4 years ago

Just for information, we are using the bundle in production since ~5 months and everyhing works fine.

Is there something missing for a new major release?

Algatux commented 4 years ago

Hi @Kocal. Before the release, we need to fix the CI to be sure that everything works in every expected environment. Actually, I do not have much time to do so.

If you have some time to investigate, please feel free to open an MR or a discussion on how to proceed to fix these issues.

Thanks a lot

Kocal commented 4 years ago

Alright, I will take a look ASAP! :)