search

Algebraic-Programming / LPF

A minimal communication layer for the implementation of immortal algorithms and for facilitating their broad use.
Apache License 2.0
5 stars 1 forks source link

eclib version 0.1 #2

Closed UnGitLambda closed 1 year ago

UnGitLambda commented 2 years ago

Results of Eyal Cohen's 3month internship supervised by Wijnand Suijlen.

This contains a first version of a multi-send-recv function using libfabric and UDP. It also contains some point to point communication function and of course an initialization for the structures used and a destruction function.

anyzelman commented 2 years ago

Crossref issue #3 and set merge target to dedicated branch

anyzelman commented 2 years ago

@UnHommeLambda @wijnand-suijlen -- thanks very much for the PR as well as the presentation earlier today!!

I'm missing the copyright headers. Would you like to add those prior to accepting into branch 3-* under issue #3 , or shall I do that? (This repo is Apache 2.0, example file headers are in any source file in master.)

Also we should add you to the NOTICE -- again, I can do that, or one of you is very welcome to make it part of this PR:) Lemme know how you like to proceed

anyzelman commented 2 years ago

Thanks!! I see a couple of files that are 3rd party. Just to confirm, those are modified from their original form right?

@wijnand-suijlen -- just to sync on a strategy for such sources, if indeed modified, we can put them in ./3rd/ectest maybe, with the Makefile?

wijnand-suijlen commented 2 years ago

We used these files from the libfabric source as template / example. I think that by the time we have a well performing all-to-all, these files will have been replaced completely by original code. That's also why this pull-request is not for the master but for a development branch.

wijnand-suijlen commented 2 years ago

So I don't have a preference for where these files are stored, as long as they are!

anyzelman commented 1 year ago

Tad bit late -- but yes, will follow the suggestion and merge into 3-towards-udp-and-libfabric-based-lpf-engines