AlgebraicJulia / ACSets.jl

ACSets: Algebraic databases as in-memory data structures
https://algebraicjulia.github.io/ACSets.jl/
MIT License
18 stars 8 forks source link

Check for nonexistent names in acset macro #110

Closed slwu89 closed 7 months ago

slwu89 commented 7 months ago

Addresses #55; this exact issue recently came up when introducing a new user to acsets, so it seemed timely to address.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f520029) 91.05% compared to head (ff51a74) 90.88%.

Files Patch % Lines
src/DenseACSets.jl 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================== - Coverage 91.05% 90.88% -0.18% ========================================== Files 22 22 Lines 2136 2140 +4 ========================================== Hits 1945 1945 - Misses 191 195 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

slwu89 commented 7 months ago

thanks @jpfairbanks, good to merge?

epatters commented 7 months ago

Thanks Sean!