search

AlgebraicJulia / ACSets.jl

ACSets: Algebraic databases as in-memory data structures
https://algebraicjulia.github.io/ACSets.jl/
MIT License
19 stars 8 forks source link

Remove `collect_or_id` in subpart accessor #131

Closed kris-brown closed 6 months ago

kris-brown commented 6 months ago

Addresses https://github.com/AlgebraicJulia/ACSets.jl/issues/128 by removing unnecessary calls to collect.

It turns out the function was unnecessary - https://github.com/AlgebraicJulia/ACSets.jl/pull/36 introduced thecollect_column which is sufficient for making sure that X[:f] returns a mutable vector copy rather than access to the direct underlying column.

(I'll be testing that this doesn't break downstream packages in the near future)

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.90%. Comparing base (a3f9f7c) to head (91a1d78).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ========================================== + Coverage 91.47% 91.90% +0.42% ========================================== Files 23 23 Lines 2089 2087 -2 ========================================== + Hits 1911 1918 +7 + Misses 178 169 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.