AlgebraicJulia / AlgebraicDynamics.jl

Building dynamical systems compositionally
https://algebraicjulia.github.io/AlgebraicDynamics.jl/
MIT License
65 stars 13 forks source link

Update compat for new Catlab version #122

Closed tylerhanks closed 1 year ago

tylerhanks commented 1 year ago

This relies on the Catlab v0.15 release and also now depends ACSets. This PR probably shouldn't be merged until AlgPetri compat is bumped to Catlab v0.15 as well. Until then, I just commented out the tests that depend on AlgPetri.

jpfairbanks commented 1 year ago

We should just merge the analogous PR on AP first. It has been autofilled by compat helper bot.

tylerhanks commented 1 year ago

Not sure why all the CI tests are failing; they passed on my machine

epatters commented 1 year ago

A new release of AlgPetri has been tagged. Also, Catlab reexports ACSets, so you can even omit importing that!

epatters commented 1 year ago

@mehalter, would you mind updating this PR to add the organization-level CI to this repo?

mehalter commented 1 year ago

Yeah definitely, I can do this first thing in the morning @epatters

epatters commented 1 year ago

Thanks Micah!

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@db1daa5). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #122 +/- ## ========================================= Coverage ? 86.04% ========================================= Files ? 4 Lines ? 516 Branches ? 0 ========================================= Hits ? 444 Misses ? 72 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mehalter commented 1 year ago

@epatters @tylerhanks I added a commit here to move to the organization level github actions and it all looks good to go 🥳

tylerhanks commented 1 year ago

Can I go ahead and merge this? @epatters @jpfairbanks