search

AlgebraicJulia / AlgebraicDynamics.jl

Building dynamical systems compositionally
https://algebraicjulia.github.io/AlgebraicDynamics.jl/
MIT License
65 stars 13 forks source link

Some cleanup after #87 #97

Closed ntfrgl closed 2 years ago

ntfrgl commented 2 years ago

When #87 switched the backend provided for DiscreteMachine from DynamicalSystems.DiscreteDynamicalSystem to DifferentialEquations.DiscreteProblem, some inconsistencies remained -- Most notably, the trajectory() method throws an error and the documentation is incomplete. This PR resolves these issues. The commits can be reviewed in logical order:

  1. Meaning-preserving refactoring of the test suite, eliminating some warnings.
  2. Main changes to the library code.
  3. Corresponding documentation update.
  4. Some more documentation edits, while we're at it.
slibkind commented 2 years ago

Hi @ntfrgl, thank you so much for your updates to AlgebraicDynamics! I really appreciate your fixes of the inconsistencies relating to DiscreteDynamics and trajectory. Your thoughtful updates to the documentation also really clarify the package!

ntfrgl commented 2 years ago

@slibkind I'm glad to hear! Thank you for your inspiring work!

slibkind commented 2 years ago

Thank you for the kind words @ntfrgl! And if you'd like to get involved more with AlgebraicDynamics, do let me know!