search

AlgebraicJulia / AlgebraicPetri.jl

Build Petri net models compositionally
https://algebraicjulia.github.io/AlgebraicPetri.jl/
MIT License
72 stars 20 forks source link

Inefficiency in `vectorfield` function #77

Closed bosonbaas closed 1 year ago

bosonbaas commented 2 years ago

The vectorfield function currently iterates through each element of the transition matrix, making each evaluation be O(ST) for number of states S and number of transitions T. This can cause significant slowdown on large sparse PetriNets, and could be improved by using a sparse representation of the transition matrix.

epatters commented 2 years ago

Do we even need the transition matrix to generate the vector field? Seems like we could just read off the needed information from the acset data structure.

bosonbaas commented 2 years ago

Yeah, I agree that'd be the most efficient way to do it.

slwu89 commented 1 year ago

I think this can be closed based on #107?

mehalter commented 1 year ago

Yeah this can be closed now :)