AlgebraicJulia / AlgebraicRelations.jl

Relational Algebra, now with more algebra!
https://www.algebraicjulia.org
MIT License
48 stars 3 forks source link

CompatHelper: bump compat for "AlgebraicPetri" to "0.7" #28

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the AlgebraicPetri package from 0.6 to 0.6, 0.7.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

mehalter commented 3 years ago

@epatters @jpfairbanks @bosonbaas how how do we feel about this GitHub Action being useful in triggering compatibility updates but unable to trigger the test suite. I've run into this with the rebase GitHub Action where it's extremely useful, but because it doesn't use a PAT, it isn't allowed to trigger other actions with it's pushes. So yes, it can make the edits to update the compatibility, but how do we know the compatibility is valid/tests are passed

mehalter commented 3 years ago

If we had a way to trigger the test action then this could be bypassed. Maybe with an action that used a PAT from a comment but I don't want the pushes/PRs from a commit to be attributed to an account which we ran into on AlgebraicPetri

bosonbaas commented 3 years ago

I'm not too familiar with the Github Actions framework, but could the PAT be used specifically to trigger the tests (keeping the github actions without the PAT for the rebase)? Or is it necessary to have a commit that's associated with a PAT in order to trigger tests in the first place?

mehalter commented 3 years ago

I think I can do some tricks to make something like the Rebase command to do a comment like \test using a PAT to just trigger the tests without a push needed. The only annoying thing is when doing a Rebase or something like the compat helper it would add that extra step in the workflow