AlgebraicJulia / AlgebraicRelations.jl

Relational Algebra, now with more algebra!
https://www.algebraicjulia.org
MIT License
48 stars 3 forks source link

Method Error in Notebook example #34

Open jmatsushita opened 1 year ago

jmatsushita commented 1 year ago

Hi there,

I'm trying to run this example notebook in VS Code. I'm using the Julia 1.8.3 kernel and I've just did add AlgebraicRelations in the package manager.

When I run the second cell (the using first cell runs) I get the following error:

MethodError: no method matching present_to_schema(::Presentation{Catlab.Theories.ThSymmetricMonoidalCategory, Symbol})
Closest candidates are:
  present_to_schema(!Matched::Symbol, !Matched::Symbol) at ~/.julia/packages/AlgebraicRelations/VrfVu/src/Presentations.jl:48

Stacktrace:
 [1] top-level scope
   @ ~/dev/workshop/julia/AlgebraicRelations.jl/examples/ml_workflow_demo/ml_demo.ipynb:18

I'm new to both Julia and the Catlab ecosystem, so apologies if I've missed something obvious!

Cheers,

Jun

jmatsushita commented 1 year ago

I think I found the problem.

I'll submit a PR to fix the notebook.

epatters commented 1 year ago

Hi, thanks for tracking down this problem and suggesting a fix. This package has been without a maintainer for a little while, but @TheCedarPrince is going to start working on it, beginning with the big refactor in #31. It may take awhile to triage these issues. Thanks for your interest and your patience!

TheCedarPrince commented 1 year ago

Yup! I am ramping up on this and will come back to this error @jmatsushita -- sorry you ran into problems! Like @epatters , I'll be picking up with a major refactor and then can revisit not only this issue but others that are outstanding. Thanks for coming through! If you have any more questions, feel free to also follow-up with us in Zulip