Clean up and tests for acset column system - Githubissues

AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language

https://www.algebraicjulia.org

MIT License

614 stars 58 forks source link

Clean up and tests for acset column system #703

Closed kris-brown closed 2 years ago

kris-brown commented 2 years ago

Internal improvements to system for acset columns:

Allow general AbstractVector and AbstractDict instances in mappings and columns
Constructors for mappings and columns
Better names for default column types
Unit tests for columns functionality that was previously only tested implicitly

This is preparation to refactor FinFunctions to use columns.

:train:

github-actions[bot] commented 2 years ago

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

[x] New features and bug fixes have unit tests
[x] New modules have tests that are ultimately called by the test runner (test/runtests.jl)
[x] Existing tests have not been deleted
[x] Code coverage >= 90% or reduction justified in PR

Documentation

[x] All exported functions, types, and constants have docstrings, written in complete sentences
[x] Citations are given for any constructions, algorithms, or code drawn from external sources

Other

[x] Style guidelines are followed, including indent width 2
[x] Changes breaking backwards compatibility have been approved