search

AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language
https://www.algebraicjulia.org
MIT License
614 stars 58 forks source link

Drawing FinFunctions using Graphviz #725

Closed slwu89 closed 1 year ago

slwu89 commented 1 year ago

Simple PR which makes it easier to visualize FinFunction using Graphviz, based on the earlier PR #655. I added some documentation to graphics/graphviz_graphs.jl regarding use of it, which you might feel should go somewhere else, but I didn't know anywhere more suitable.

The unit tests are too minimal, but I had trouble finding out how to get at the statements within Subgraph objects. @epatters if you have any suggestions as to how to go about this, I'd be very happy to include more substantive tests!

[EDIT]: non-trivial tests implemented https://github.com/AlgebraicJulia/Catlab.jl/pull/725/commits/d19361127155e9af7bdfaa950df7447ec2e8b2ae

slwu89 commented 1 year ago

Hi @epatters, just wanted to check in about this PR. Thanks!

epatters commented 1 year ago

Hi @slwu89, sorry I took forever to review this nice PR. Since I can't push to your branch, I'm replacing this PR with #772.

slwu89 commented 1 year ago

Thanks @epatters!