AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language
https://www.algebraicjulia.org
MIT License
614 stars 58 forks source link

Improve finite functor error messages #762

Closed KevinDCarlson closed 1 year ago

KevinDCarlson commented 1 year ago

Fixes #598 by having @finfunctor tell the user which morphisms are mapped inconsistently with the object map. There is code ready to update @finfunctor to check preservation of equations between morphisms in the domain category, too, once we have some ability to check equality of homs.

github-actions[bot] commented 1 year ago

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

Documentation

Other

olynch commented 1 year ago

@mehalter @KevinArlin, what's our feeling about the failing tests on nightly? Is this a bug in nightly? Should we disable nightly CI until it's fixed? I don't want to merge this with failing tests.

epatters commented 1 year ago

Oh, @KevinArlin, I see that in #765 you also add a get_unnaturalities function. I think I'd prefer a different naming convention but, more importantly, this does address my complaint about having inconsistent APIs for naturality and functorality testing.