Fix implicit conversion for union types with `AttrVar` - Githubissues

AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language

https://www.algebraicjulia.org

MIT License

614 stars 58 forks source link

Fix implicit conversion for union types with `AttrVar` #783

Closed mehalter closed 1 year ago

github-actions[bot] commented 1 year ago

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

[x] New features and bug fixes have unit tests
[x] New modules have tests that are ultimately called by the test runner (test/runtests.jl)
[x] Existing tests have not been deleted
[x] Code coverage >= 90% or reduction justified in PR

Documentation

[x] All exported functions, types, and constants have docstrings, written in complete sentences
[x] Citations are given for any constructions, algorithms, or code drawn from external sources

Other

[x] Style guidelines are followed, including indent width 2
[x] Changes breaking backwards compatibility have been approved

mehalter commented 1 year ago

@epatters I updated one of the tests to test this. I also verified that with the test updates the tests fail on the current master branch