AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language
https://www.algebraicjulia.org
MIT License
599 stars 56 forks source link

Rename `Slices` to `SliceCategories` to avoid name conflict #883

Closed KevinDCarlson closed 5 months ago

KevinDCarlson commented 5 months ago

Julia complains all the time now about Catlab and Base both exporting the word Slices. Can we just change the name? This would be a breaking change, not sure whether there's a better approach but I think leaving it as is isn't a serious option in that the attempted export wouldn't actually work if you tried to use Slices unqualified.

epatters commented 5 months ago

Yes, we should change the name. I would suggest renaming the module to SliceCategories.

I'm not sure why this PR deletes the modules.

KevinDCarlson commented 5 months ago

I think I just didn't add the renamed files on the first commit?

epatters commented 5 months ago

Thanks! Can you please rebase and force-push so we get a clean commit?

KevinDCarlson commented 5 months ago

Yep, done.