Implement bipartite property graphs and refactor graphviz bipartite graph methods - Githubissues

AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language

https://www.algebraicjulia.org

MIT License

608 stars 58 forks source link

Implement bipartite property graphs and refactor graphviz bipartite graph methods #895

Open slwu89 opened 6 months ago

slwu89 commented 6 months ago

Address #888

Please note the changes to https://github.com/AlgebraicJulia/Catlab.jl/pull/895/files#diff-77b8985182dac144d246a8e8f0becf17233222f79879274682b78adf2e454ca4 I suspect it was a typo that some small subset of the generic bipartite graph methods have argument type AbstractBipartiteGraph rather than HasBipartiteGraph (a narrower type instead of a wider type), so I changed that.

github-actions[bot] commented 6 months ago

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

[ ] New features and bug fixes have unit tests
[ ] New modules have tests that are ultimately called by the test runner (test/runtests.jl)
[ ] Existing tests have not been deleted
[ ] Code coverage >= 90% or reduction justified in PR

Documentation

[ ] All exported functions, types, and constants have docstrings, written in complete sentences
[ ] Citations are given for any constructions, algorithms, or code drawn from external sources

Other

[ ] Style guidelines are followed, including indent width 2
[ ] Changes breaking backwards compatibility have been approved