`SigmaMigrationFunctor` method uses an undefined variable

AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language

https://www.algebraicjulia.org

MIT License

599 stars 56 forks source link

`SigmaMigrationFunctor` method uses an undefined variable #903

Closed neonWhiteout closed 1 month ago

neonWhiteout commented 2 months ago

SigmaMigrationFunctor(f,T′,T) = SigmaMigrationFunctor(f,d,T()) on line 193 of FunctorialDataMigrations.jl

epatters commented 2 months ago

Thanks for the report. @kris-brown, could you take a look at this one?

kris-brown commented 2 months ago

Hi @neonWhiteout, can you share what context you called this in? This method seems quite extraneous (no type information on the parameters) and the tests pass without it, so I'm leaning towards fixing this bug by just deleting the method.

You could also test your code works in the branch here, which has the method deleted: https://github.com/AlgebraicJulia/Catlab.jl/pull/906