AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language
https://www.algebraicjulia.org
MIT License
599 stars 56 forks source link

Fix Heyting subtraction for ACSets with variables #909

Closed kris-brown closed 1 month ago

kris-brown commented 1 month ago

The subtraction operation was not brought up to date with AttrVar refactor, so a minor tweak is needed.

It uses all_subparts, which gets all the other parts that a part is referencing; however, that method searched over homs and not arrows. When this change is made, the correct behavior is recovered.

The relevance of this is that complement is used in this PR https://github.com/AlgebraicJulia/AlgebraicRewriting.jl/pull/62