Fix constructor of acset from `FinDomFunctor` in varacset case - Githubissues

AlgebraicJulia / Catlab.jl

A framework for applied category theory in the Julia language

https://www.algebraicjulia.org

MIT License

608 stars 58 forks source link

Fix constructor of acset from `FinDomFunctor` in varacset case #917

Closed KevinDCarlson closed 3 months ago

KevinDCarlson commented 3 months ago

The constructor (T)(::FinDomFunctor) where T<:ACSet did not previously add any parts at AttrTypes, which is necessary in case where some of the input's attributes take AttrVar values. We now add such AttrVars, only when they're definitely needed, to avoid dangling AttrVars, which are quite dangerous.

github-actions[bot] commented 3 months ago

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

[x] New features and bug fixes have unit tests
[x] New modules have tests that are ultimately called by the test runner (test/runtests.jl)
[x] Existing tests have not been deleted
[x] Code coverage >= 90% or reduction justified in PR

Documentation

[x] All exported functions, types, and constants have docstrings, written in complete sentences
[x] Citations are given for any constructions, algorithms, or code drawn from external sources

Other

[x] Style guidelines are followed, including indent width 2
[x] Changes breaking backwards compatibility have been approved