search

AlgebraicJulia / Decapodes.jl

A framework for composing and simulating multiphysics systems
https://algebraicjulia.github.io/Decapodes.jl/dev/
MIT License
46 stars 14 forks source link

In generating simulate, return nothing, for Enzyme compatibility #244

Closed jClugstor closed 2 weeks ago

jClugstor commented 2 weeks ago

Enzyme expects these functions to return nothing to be autodiffable. Is this ok?

lukem12345 commented 2 weeks ago

You're right. The value returned here shouldn't matter. I'll merge this if tests pass and docs build.

lukem12345 commented 2 weeks ago

It looks like the allocations test failed, but that's okay because it's fragile.

An old test was relying on that output, but that should be updated.

We'll update those tests on our end and merge.