search

AlgebraicJulia / DiagrammaticEquations.jl

MIT License
9 stars 1 forks source link

Move Decapodes ACSet to InterTypes file #11

Closed olynch closed 8 months ago

olynch commented 8 months ago

Supersedes https://github.com/AlgebraicJulia/Decapodes.jl/pull/184

jpfairbanks commented 8 months ago

@quffaro I can't see why the docs are failing on buildkite. The build log is empty when I log in on my ipad both safari and chrome. A possible reason would be that the docs Project.tool needs to be updated to use ACSets.jl Or maybe some display methods are missing on InterTypes objects.

olynch commented 8 months ago

@jpfairbanks should we merge this despite the docs failing? What's the action item here.

quffaro commented 8 months ago

@olynch I've determined the root cause of the issue (docs failing on buildkite).

When you pushed your commit, Buildkite was running two agents: one on the daemon node and one on a local Macbook (mine?). The issue was that the agent running on my Macbook picked up the job to run in its own buildkite directory, so it failed when the "module" function was not present.

I stopped that agent so the daemon was remained and retried the build. It appears to be working now, but I'm awaiting for the pipeline to complete.

for your awareness @jpfairbanks

EDIT: Pipeline run completed!

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fe06d15) 57.30% compared to head (f0c96dd) 57.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11 +/- ## ========================================== + Coverage 57.30% 57.36% +0.05% ========================================== Files 12 12 Lines 780 781 +1 ========================================== + Hits 447 448 +1 Misses 333 333 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.