search

AlgebraicJulia / DiagrammaticEquations.jl

MIT License
9 stars 1 forks source link

Reexport Catlab functionality #44

Closed GeorgeR227 closed 1 month ago

GeorgeR227 commented 3 months ago

Added apex from DiagrammaticEquations and @relation, to_graphviz from Catlab to exports. These are required to use the composition code and the visualization code.

GeorgeR227 commented 3 months ago

Close #43

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.80%. Comparing base (d2fa4a4) to head (73664f5). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #44 +/- ## ======================================= Coverage 86.80% 86.80% ======================================= Files 13 13 Lines 894 894 ======================================= Hits 776 776 Misses 118 118 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lukem12345 commented 3 months ago

This might be tailoring a little too close to the happy path. What about when we want to compose Decapodes with oplus. Why only export some composition functionality from Catlab but not all?

@jpfairbanks thoughts?

GeorgeR227 commented 3 months ago

I was just adding what I thought were the most often used functions. We can add some more if we want but if we start re-exporting too much then at that point it'd be better to just get the user to have Catlab.