search

AlgebraicJulia / DiagrammaticEquations.jl

MIT License
12 stars 1 forks source link

Work on summation inference #48

Closed GeorgeR227 closed 5 months ago

GeorgeR227 commented 5 months ago

Cleans up the summation inference code. This will now only propagate form types and do basic type checking.

lukem12345 commented 5 months ago

@GeorgeR227 Your last few PRs have had spurious changes to lines. I guess this is because of line ending encodings or something. I think you can configure your git client to ignore these.

GeorgeR227 commented 5 months ago

I think actually this is to do with hanging whitespace at the end of lines. My git client does tell me if the encoding are different.

However I agree with you in that these are annoying now because they aren't the purpose of these PRs.

GeorgeR227 commented 5 months ago

Also I'm moving this PR to #49.

lukem12345 commented 5 months ago

I think actually this is to do with hanging whitespace at the end of lines. My git client does tell me if the encoding are different.

Yeah maybe spot check a few of these. It usually highlights when whitespace inside of line is added or removed.

It makes the git blame misleading when tracking things down.

GeorgeR227 commented 5 months ago

Yeah this is the case, if you check https://github.com/AlgebraicJulia/DiagrammaticEquations.jl/blob/41df8def1e64c225ed2e5d4dd44420fb83ac29f6/test/composition.jl#L13

there is some whitespace at the end but if I edit the file in anyway it's removed and caught in the commit.

lukem12345 commented 5 months ago

Ok, maybe turn off the aggressive linting setting or just use git add at the command line instead.

GeorgeR227 commented 5 months ago

I'll open a linting issue with a reference this problem. We have an issue about this in Decapodes but not here.