search

AlgebraicJulia / GATlab.jl

GATlab: a computer algebra system based on generalized algebraic theories (GATs)
https://algebraicjulia.github.io/GATlab.jl/
MIT License
23 stars 2 forks source link

Pass model via Base.getindex #106

Closed olynch closed 11 months ago

olynch commented 11 months ago

Keyword arguments don't play well with dispatch, and we don't want the model to be the first parameter when unwrapped by WithModel because models might be elements of another model, so instead we pass in the model via stuff like id[FinSetC()](3).

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (7f93f97) 96.82% compared to head (6d791a3) 96.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #106 +/- ## ========================================== - Coverage 96.82% 96.82% -0.01% ========================================== Files 25 25 Lines 1449 1447 -2 ========================================== - Hits 1403 1401 -2 Misses 46 46 ``` | [Files Changed](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia) | Coverage Δ | | |---|---|---| | [src/stdlib/models/FinMatrices.jl](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvRmluTWF0cmljZXMuamw=) | `100.00% <ø> (ø)` | | | [src/stdlib/models/FinSets.jl](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvRmluU2V0cy5qbA==) | `92.30% <ø> (ø)` | | | [src/stdlib/models/GATs.jl](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvR0FUcy5qbA==) | `100.00% <ø> (ø)` | | | [src/stdlib/models/Nothings.jl](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvTm90aGluZ3Muamw=) | `100.00% <ø> (ø)` | | | [src/models/ModelInterface.jl](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL21vZGVscy9Nb2RlbEludGVyZmFjZS5qbA==) | `97.63% <100.00%> (ø)` | | | [src/stdlib/models/SliceCategories.jl](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvU2xpY2VDYXRlZ29yaWVzLmps) | `88.88% <100.00%> (ø)` | | | [src/syntax/TheoryInterface.jl](https://app.codecov.io/gh/AlgebraicJulia/GATlab.jl/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N5bnRheC9UaGVvcnlJbnRlcmZhY2Uuamw=) | `97.87% <100.00%> (-0.09%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.