Closed KevinDCarlson closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
345cc44
) 96.61% compared to head (b885d2d
) 96.61%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
With https://github.com/AlgebraicJulia/GATlab.jl/pull/118, migrate
is now a function, not a macro! Would this make things compatible with DataMigrations?
I guess so, right? That's exporting @migrate
and migrate
, which don't collide. I'm still skeptical about having both of those names present and meaning dramatically different things, in terms of UX. It seems like a pretty common Julian practice to have @f
be a sugared version of f
.
Err, wait...Then I have to think about migrate
itself in DataMigrations
. That's exported too and we don't want to have those collide either.
My suggestion would still be to have migrate_model
and/or @migrate_model
. It's only a few more characters but IMO makes it notably more clear what the function/macro does.
Great, I updated that PR!
I thought we'd agreed to name
@migrate
something different to avoid collision with DataMigrations, so renamed it here, I don't think we want the DataMigrations one to be a method of the Gatlab one. Also a couple of superficial edits to docs. Let me know any thoughts.