search

AlgebraicJulia / GATlab.jl

GATlab: a computer algebra system based on generalized algebraic theories (GATs)
https://algebraicjulia.github.io/GATlab.jl/
MIT License
24 stars 2 forks source link

Petri Net to Lens #55

Closed kris-brown closed 1 year ago

kris-brown commented 1 year ago

Trms? In my SymExprs?

Additionally, Labelled Petri Net to Lens converter.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 62.12% and project coverage change: -0.76 :warning:

Comparison is base (c260dea) 74.02% compared to head (f0ec7df) 73.27%.

:exclamation: Current head f0ec7df differs from pull request most recent head 79f1264. Consider uploading reports for the commit 79f1264 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mtk #55 +/- ## ========================================== - Coverage 74.02% 73.27% -0.76% ========================================== Files 20 21 +1 Lines 1074 1055 -19 ========================================== - Hits 795 773 -22 - Misses 279 282 +3 ``` | [Impacted Files](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia) | Coverage Δ | | |---|---|---| | [src/stdlib/models/ContextMaps.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvQ29udGV4dE1hcHMuamw=) | `68.42% <0.00%> (ø)` | | | [src/stdlib/models/MTKInterop.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvTVRLSW50ZXJvcC5qbA==) | `0.00% <0.00%> (ø)` | | | [src/util/Names.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3V0aWwvTmFtZXMuamw=) | `61.53% <0.00%> (-5.13%)` | :arrow_down: | | [src/dsl/TheoryMacros.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL2RzbC9UaGVvcnlNYWNyb3Muamw=) | `87.20% <50.00%> (-0.71%)` | :arrow_down: | | [src/dsl/Parsing.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL2RzbC9QYXJzaW5nLmps) | `79.36% <66.66%> (-2.83%)` | :arrow_down: | | [src/stdlib/models/Petri.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvUGV0cmkuamw=) | `100.00% <100.00%> (ø)` | | | [src/stdlib/models/SimpleLenses.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N0ZGxpYi9tb2RlbHMvU2ltcGxlTGVuc2VzLmps) | `80.00% <100.00%> (ø)` | | | [src/syntax/Theories.jl](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N5bnRheC9UaGVvcmllcy5qbA==) | `73.21% <100.00%> (+0.99%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/55/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jpfairbanks commented 1 year ago

Can we rename to_lens to symbolic_dynamics or lens_dynamics or something less OOP?

jpfairbanks commented 1 year ago

I resolved the merge conflicts in the web GUI. Now we can't rebase and merge commits and squashing are disabled for this repo.

olynch commented 1 year ago

I resolved the merge conflicts in the web GUI. Now we can't rebase and merge commits and squashing are disabled for this repo.

Yeah, idk what the github "resolve merge conflicts action" actually does; I rebased this on top of mtk using magit and hopefully it should work now.

olynch commented 1 year ago

The windows failure is a CI failure, not a code failure...