search

AlgebraicJulia / GATlab.jl

GATlab: a computer algebra system based on generalized algebraic theories (GATs)
https://algebraicjulia.github.io/GATlab.jl/
MIT License
23 stars 2 forks source link

fix presentation parser #99

Closed kris-brown closed 11 months ago

kris-brown commented 11 months ago

Ignore LineNumberNodes when parsing presentation. Addresses https://github.com/AlgebraicJulia/GATlab.jl/issues/94

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (7a20340) 95.64% compared to head (fb0f5f5) 95.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #99 +/- ## ======================================= Coverage 95.64% 95.64% ======================================= Files 22 22 Lines 1148 1148 ======================================= Hits 1098 1098 Misses 50 50 ``` | [Files Changed](https://app.codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia) | Coverage Δ | | |---|---|---| | [src/syntax/Presentations.jl](https://app.codecov.io/gh/AlgebraicJulia/Gatlab.jl/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AlgebraicJulia#diff-c3JjL3N5bnRheC9QcmVzZW50YXRpb25zLmps) | `97.61% <88.88%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

olynch commented 11 months ago

This should store the line nodes in the scope.