AlgebraicJulia / Semagrams.jl

A graphical editor for graph-like structures
https://algebraicjulia.github.io/Semagrams.jl/
MIT License
94 stars 10 forks source link

Refactor for embedding support #141

Closed olynch closed 11 months ago

netlify[bot] commented 1 year ago

Deploy Preview for semagrams failed.

Name Link
Latest commit fbedd7709460d8d0a523bfd180ff8ce22ae771f1
Latest deploy log https://app.netlify.com/sites/semagrams/deploys/64d6df4ffb11240008bbaebb
olynch commented 1 year ago

Some thoughts on the direction that this is going.

  1. We need a trial application that we embed Semagrams in for me to figure out what the API should be, or how things would work at all.
  2. Now that a Semagram is more directly just the display of the actual ACSet, I think it makes sense to eliminate the Entity/Part distinction, @sjbreiner should be happy about that. What used to be the UI viewport is now just going to be handled outside of the Semagram, in a way that doesn't have to conform to the Semagrams paradigm.
  3. The way that I'm redesigning bindings by splitting up the "hook" and the "action", it should be easier to automatically generate a help message.
olynch commented 1 year ago

Most actions should only need the stuff in here: https://github.com/AlgebraicJulia/Semagrams.jl/blob/34b2e4c519b8306bbba19e08ddf902ab4c815bf2/scala/apps/graph/src/Main.scala#L61. Does it make sense to have this class?

We have a trait that we extend in order to make the display. Should we also have a trait that we extend in order to make the control process? How does the control process interact with the rest of the app?

olynch commented 11 months ago

replaced by dev