search

AlgebraicJulia / Semagrams.jl

A graphical editor for graph-like structures
https://algebraicjulia.github.io/Semagrams.jl/
MIT License
91 stars 10 forks source link

Externalized #142

Closed olynch closed 7 months ago

olynch commented 9 months ago

@sjbreiner you should develop in draft PRs for visibility.

netlify[bot] commented 9 months ago

Deploy Preview for semagrams failed.

Name Link
Latest commit 052e84bd241172508f063b2285ef63951e206ebe
Latest deploy log https://app.netlify.com/sites/semagrams/deploys/64ff3b7ff296d900086aa766
sjbreiner commented 9 months ago

Hi @olynch,

I think this is ready to review. If it looks good I can try to move over the petri net editor next week (dwd requires more work, I think).

Main changes: 1) I took most of the code in Main and moved it into Semagrams.scala, inside a subclass ACSemagram. This should maybe be merged into the base trait? I also packaged the semagram element together with accessors and modifiers to make it easier to use externally. 2) I built a table widget with toggleable cells and some convenience methods for attaching them to a semagram. I've got hovering and editing working both ways. 3) I added a MsgEvent to handle external updates. Possibly this should be moved over to the outbox, or that could just be removed. 3) I also added a Blur event to fix a problem with corrupted keyboard state.

@sjbreiner you should develop in draft PRs for visibility. Sure thing.

I can't remember how to run the formatter. Is there a way to run it automatically if checkFormat fails?

Let me know if you have any questions.

Spencer

sjbreiner commented 9 months ago

Ps.

The test framework isn't working for me locally. It can't find the Test object extended by the test module in build.sc.

Do you know what I need to set up or install locally to make that work?