AlgebraicJulia / StockFlow.jl

https://algebraicjulia.github.io/StockFlow.jl/
MIT License
65 stars 6 forks source link

Foot error messages #86

Closed neonWhiteout closed 10 months ago

neonWhiteout commented 1 year ago

Foot and feet correctly throw errors, now, instead of needing an eval. Motivated by #80

neonWhiteout commented 1 year ago
if length(block.args) < 2 # case for create_foot(:())
                return error("Cannot create foot with no arguments.")

This would also trigger in the case where the expression has 1 argument, so something like :((A,)) would fail here

neonWhiteout commented 1 year ago

You closed this without merging, should I change something here? @Xiaoyan-Li

Xiaoyan-Li commented 1 year ago

You closed this without merging, should I change something here? @Xiaoyan-Li

Sorry, no, I just closed it accidentally. Reopen just now

neonWhiteout commented 1 year ago

Ah boy give me a few min.

neonWhiteout commented 1 year ago

K throw this one in the trash for now.

neonWhiteout commented 1 year ago

Passes tests on my end and shouldn't have any affect on the notebooks.

neonWhiteout commented 1 year ago

Nevermind it failed the notebook examples, need to figure out why...

neonWhiteout commented 1 year ago

@Saityi I don't know why this is failing the notebooks, seems like they fail to install IJulia and Conda? Any ideas?

neonWhiteout commented 1 year ago

Fails notebook tests, but I think there's something screwed up with them

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (781a54a) 49.93% compared to head (e82fa18) 50.03%. Report is 16 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ========================================== + Coverage 49.93% 50.03% +0.09% ========================================== Files 9 9 Lines 1524 1525 +1 ========================================== + Hits 761 763 +2 + Misses 763 762 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.