Closed neonWhiteout closed 10 months ago
if length(block.args) < 2 # case for create_foot(:())
return error("Cannot create foot with no arguments.")
This would also trigger in the case where the expression has 1 argument, so something like :((A,)) would fail here
You closed this without merging, should I change something here? @Xiaoyan-Li
You closed this without merging, should I change something here? @Xiaoyan-Li
Sorry, no, I just closed it accidentally. Reopen just now
Ah boy give me a few min.
K throw this one in the trash for now.
Passes tests on my end and shouldn't have any affect on the notebooks.
Nevermind it failed the notebook examples, need to figure out why...
@Saityi I don't know why this is failing the notebooks, seems like they fail to install IJulia and Conda? Any ideas?
Fails notebook tests, but I think there's something screwed up with them
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
781a54a
) 49.93% compared to head (e82fa18
) 50.03%. Report is 16 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Foot and feet correctly throw errors, now, instead of needing an eval. Motivated by #80