Closed lukem12345 closed 8 months ago
@jpfairbanks If tests pass this will be good to merge upon your review.
@jpfairbanks I will get back to working on this at 4:15, but if the fix is obvious to you, you can push here in the meantime.
@jpfairbanks
Tests pass locally. These are the contents of harmonic_oscillator.json
. Please advise on if this is the JSON we want:
{
"annotations": [
{
"note": {
"str": "The X variable.",
"_type": "Name"
},
"type": "Form0",
"entity": "X",
"_type": "Annotation"
}
],
"header": {
"description": "A Simple Harmonic Oscillator as a Diagrammatic Equation",
"name": "harmonic_oscillator",
"_type": "Header",
"model_version": "v1.0",
"schema": "modelreps.io/DecaExpr",
"schema_name": "DecaExpr"
},
"_type": "ASKEMDecaExpr",
"model": {
"context": [
{
"var": "X",
"dim": "Form0",
"space": "Point"
},
{
"var": "V",
"dim": "Form0",
"space": "Point"
},
{
"var": "k",
"dim": "Constant",
"space": "Point"
}
],
"_type": "DecaExpr",
"equations": [
{
"rhs": {
"name": "V",
"_type": "Var"
},
"lhs": {
"var": {
"name": "X",
"_type": "Var"
},
"_type": "Tan"
},
"_type": "Eq"
},
{
"rhs": {
"args": [
{
"name": "-1",
"_type": "Lit"
},
{
"name": "k",
"_type": "Var"
},
{
"name": "X",
"_type": "Var"
}
],
"_type": "Mult"
},
"lhs": {
"var": {
"name": "V",
"_type": "Var"
},
"_type": "Tan"
},
"_type": "Eq"
}
]
}
}
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
0ea6f64
) 81.74% compared to head (529aa2e
) 81.57%.
Files | Patch % | Lines |
---|---|---|
src/decapodes.jl | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM
Swapped in DiagrammaticEquations in the docs. Will merge whenever they pass.
Close #32