search

Algo-Phantoms / Algo-ScriptML

Scripts of Machine Learning Algorithms from Scratch. Implementations of machine learning models and algorithms using nothing but NumPy with a focus on accessibility. Aims to cover everything from basic to advance.
MIT License
90 stars 66 forks source link

KNN on iris dataset #164

Closed saumyasinghz closed 3 years ago

saumyasinghz commented 3 years ago

Simple code for KNN on iris dataset from UCI machine learning repository.

ashwani-rathee commented 3 years ago

@saumyasinghz This generally looks good and is a good example Though it's very narrow and focussed on IRIS only,would have appreciated a class-type implementation of the method more but got to check with @geekquad

saumyasinghz commented 3 years ago

Okay, then you can merge this as data-based and I will create one more pull request based on class type implementation.

ashwani-rathee commented 3 years ago

@geekquad can you clarify on this whether we need this or not?Since we need class type implementation only

geekquad commented 3 years ago

Certainly not @ashwani-rathee. Hey @saumyasinghz, please go through the Contributing Guidelines. We need a class-type implementation of the algorithm/technique from scratch using nothing but NymPy, focusing more on the implementation and not on the application. No external modules/libraries are allowed. To know more about classes in Python please refer here.